Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb+CI: Flake on unicode-range.html ref test #24163

Open
AtkinsSJ opened this issue Apr 29, 2024 · 1 comment
Open

LibWeb+CI: Flake on unicode-range.html ref test #24163

AtkinsSJ opened this issue Apr 29, 2024 · 1 comment
Labels
ci-flakiness

Comments

@AtkinsSJ
Copy link
Member

This test is inconsistently failing on CI.

Expected:
unicode-range-ref

Actual:
unicode-range

Here's the file for easy reference:

<!DOCTYPE html>
<html>
<head>
    <link rel="match" href="reference/unicode-range-ref.html" />
    <style>
        @font-face {
            font-family: 'HashFont';
            src: url('assets/HashSans.woff');
            unicode-range: U+0041; /* Only letter 'A' */
        }

        .text {
            font-family: 'HashFont', 'SerenitySans';
            font-size: 100px;
        }
    </style>
</head>
<body>
    <div class="text">AB</div>
</body>
</html>

As far as I can tell, CSS resources don't delay the document load event, so we won't be waiting for HashFont.woff to load before we take the screenshot. It's then a race condition whether it loads in time or not. But I might be completely off with that. 😅
@ADKaster
Copy link
Member

ADKaster commented Apr 30, 2024 •
edited

This is most commonly see on macOS on Azure, but it's possible that that's just the slowest CI runner we have at the moment

Edit: I stand corrected, it shows up in Linux as well. https://dev.azure.com/SerenityOS/SerenityOS/_build/results?buildId=47075&view=logs&jobId=2566f013-1391-5cbe-90ce-ae4ec398ae06&j=2566f013-1391-5cbe-90ce-ae4ec398ae06&t=bbb6774a-3205-5d19-3510-d01930cbed73

@ADKaster ADKaster mentioned this issue Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-flakiness
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AtkinsSJ @ADKaster