Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc string for CDP Commands #9929

Merged
merged 2 commits into from Oct 15, 2021
Merged

Conversation

mastrzyz
Copy link
Contributor

@mastrzyz mastrzyz commented Oct 14, 2021

Fixed spelling issue and fixed the return statement to be of Promise

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] I have read the contributing document.
  • [x ] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

Fixed spelling issue and fixed the return statement to be of Promise

Fixed spelling issue and fixed the return statement to be of Promise<string>
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2021

CLA assistant check
All committers have signed the CLA.

@mastrzyz
Copy link
Contributor Author

By the way, is there any current work to update the typing information for Selenium 4? I can try and add some of the v4 features into it.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mastrzyz! Congrats on your first contribution 🎉

@diemol diemol merged commit a501e6a into SeleniumHQ:trunk Oct 15, 2021
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Fixed spelling issue and fixed the return statement to be of Promise<string>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants