Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Remove Edge USE_CHROMIUM flag #9921

Merged
merged 1 commit into from Oct 14, 2021

Conversation

bwalderman
Copy link
Contributor

Description

Removing the ms:edgeChromium a.k.a. USE_CHROMIUM flag from the Java bindings as this should no longer be used.

Motivation and Context

The flag was originally introduced as a hint for middleware like Selenium Grid to let the client select either EdgeHTML or Chromium-based Edge. In #9166 the decision was made to remove EdgeHTML support from Selenium 4 and make Edge Chromium the default and only supported Edge version. Since there are no longer plans to support running both Edge implementations side-by-side, this flag can be removed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @bwalderman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants