You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the past the HttpClient did take care of stale connections and did reconnect the TCP socket. When switching to WebSockets / BiDi this has to be handled by the application. Otherwise users might have negative experience when selenium will switch to BiDi and there might be alot of issue tickets (as users did use selenium in the past without problems).
I have experienced this when testing BiDi via VPN and the VPN did break and reconnect automatically.
It might be good to reconnect the WebSocket when it breaks. This might require the server to have a outgoing message que and the client to check the message has been received before (in case the server did resent due to a IOException while sending the last time). The reconnect has to be initiated by the client, this might require sending ping / pong requests in case the connection is idle (to detect the sockets are broken).
What do you think, is this needed? Or at least have a plan if users complain about this?
Usage example
Running tests in a world of not perfect connectivity (VPN / switch from WiFi to docking)
The text was updated successfully, but these errors were encountered:
@joerg1985, thank you for creating this issue. We will troubleshoot it as soon as we can.
Info for maintainers
Triage this issue by using labels.
If information is missing, add a helpful comment and then I-issue-template label.
If the issue is a question, add the I-question label.
If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable G-* label, and it will provide the correct link and auto-close the
issue.
After troubleshooting the issue, please add the R-awaiting answer label.
Feature and motivation
In the past the HttpClient did take care of stale connections and did reconnect the TCP socket. When switching to WebSockets / BiDi this has to be handled by the application. Otherwise users might have negative experience when selenium will switch to BiDi and there might be alot of issue tickets (as users did use selenium in the past without problems).
I have experienced this when testing BiDi via VPN and the VPN did break and reconnect automatically.
It might be good to reconnect the WebSocket when it breaks. This might require the server to have a outgoing message que and the client to check the message has been received before (in case the server did resent due to a IOException while sending the last time). The reconnect has to be initiated by the client, this might require sending ping / pong requests in case the connection is idle (to detect the sockets are broken).
What do you think, is this needed? Or at least have a plan if users complain about this?
Usage example
Running tests in a world of not perfect connectivity (VPN / switch from WiFi to docking)
The text was updated successfully, but these errors were encountered: