Fix wrong type annotations for "env" it's a dict not a string #10072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jedie
added a commit
to jedie/django-tools
that referenced
this pull request
Nov 22, 2021
In #21 i found a bug in chrome driver: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3358 Add a work-a-round for this, by set LANG/LANGUAGE environment variables. btw. `env` argument has a wrong type annotation in upstream, see: SeleniumHQ/selenium#10072
jedie
added a commit
to jedie/django-tools
that referenced
this pull request
Nov 22, 2021
In #21 i found a bug in chrome driver: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3358 Add a work-a-round for this, by set LANG/LANGUAGE environment variables. btw. `env` argument has a wrong type annotation in upstream, see: SeleniumHQ/selenium#10072
jedie
added a commit
to jedie/django-tools
that referenced
this pull request
Nov 22, 2021
In #21 i found a bug in chrome driver: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3358 Add a work-a-round for this, by set LANG/LANGUAGE environment variables. btw. `env` argument has a wrong type annotation in upstream, see: SeleniumHQ/selenium#10072
jedie
added a commit
to jedie/django-tools
that referenced
this pull request
Nov 22, 2021
In #21 i found a bug in chrome driver: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3358 Add a work-a-round for this, by set LANG/LANGUAGE environment variables. btw. `env` argument has a wrong type annotation in upstream, see: SeleniumHQ/selenium#10072
jedie
added a commit
to jedie/django-tools
that referenced
this pull request
Nov 22, 2021
In #21 i found a bug in chrome driver: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3358 Add a work-a-round for this, by set LANG/LANGUAGE environment variables. btw. `env` argument has a wrong type annotation in upstream, see: SeleniumHQ/selenium#10072
jedie
added a commit
to jedie/django-tools
that referenced
this pull request
Nov 22, 2021
In #21 i found a bug in chrome driver: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3358 Add a work-a-round for this, by set LANG/LANGUAGE environment variables. btw. `env` argument has a wrong type annotation in upstream, see: SeleniumHQ/selenium#10072
AutomatedTester
approved these changes
Nov 22, 2021
|
Thanks for the PR! |
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env used here:
selenium/py/selenium/webdriver/common/service.py
Line 48 in adeca5c
selenium/py/selenium/webdriver/common/service.py
Line 71 in adeca5c