Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split OpenTelemetry command #10009

Merged

Conversation

llatinov
Copy link
Contributor

@llatinov llatinov commented Nov 3, 2021

Split OpenTelemetry command in order to facilitate search by tags

Fixes #9942

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Split OpenTelemetry command in order to facilitate search by tags

Fixes SeleniumHQ#9942
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2021

CLA assistant check
All committers have signed the CLA.

@pujagani
Copy link
Contributor

Thank you so much for your contribution! @llatinov I was able to locally test it out and its works as expected :)
Screenshot 2021-11-22 at 4 05 50 PM

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujagani pujagani merged commit 24a9c50 into SeleniumHQ:trunk Nov 22, 2021
@llatinov llatinov deleted the feat/9942_split_open_telemetry_command branch November 23, 2021 15:28
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Split OpenTelemetry command in order to facilitate search by tags

Fixes SeleniumHQ#9942

Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: OpenTelementry tracing: split "command" tag to ease the search
3 participants