Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected condition for checking attribute value #9881

Merged
merged 3 commits into from Oct 12, 2021
Merged

Expected condition for checking attribute value #9881

merged 3 commits into from Oct 12, 2021

Conversation

joesho112358
Copy link
Contributor

Adds expected condition function text_to_be_present_in_element_attribute
for checking if an element's attribute contains certain text.

Fixes #7628

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Adds expected condition function text_to_be_present_in_element_attribute
 for checking if an element's attribute contains certain text.

Fixes #7628
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2021

Codecov Report

Merging #9881 (9f5912e) into trunk (3b84577) will increase coverage by 0.04%.
The diff coverage is 60.00%.

❗ Current head 9f5912e differs from pull request most recent head 46d0cc2. Consider uploading reports for the commit 46d0cc2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #9881      +/-   ##
==========================================
+ Coverage   45.01%   45.06%   +0.04%     
==========================================
  Files          83       83              
  Lines        5536     5541       +5     
  Branches      251      251              
==========================================
+ Hits         2492     2497       +5     
  Misses       2793     2793              
  Partials      251      251              
Impacted Files Coverage Δ
.../selenium/webdriver/support/expected_conditions.py 33.17% <36.36%> (+0.17%) ⬆️
py/selenium/webdriver/ie/webdriver.py 65.27% <66.66%> (+6.30%) ⬆️
py/selenium/__init__.py 100.00% <100.00%> (ø)
py/selenium/webdriver/__init__.py 100.00% <100.00%> (ø)
.../selenium/webdriver/common/desired_capabilities.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2d017...46d0cc2. Read the comment docs.

@shs96c shs96c added the C-py label Oct 4, 2021
@AutomatedTester AutomatedTester merged commit c096326 into SeleniumHQ:trunk Oct 12, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Adds expected condition function text_to_be_present_in_element_attribute
 for checking if an element's attribute contains certain text.

Fixes SeleniumHQ#7628

Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extending text_to_be_present_in_element_value functionality
5 participants