[py]: Propagate stderr to exceptions when selenium manager fails
#11329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did CI change? I'd definitely expect full python tests to run against this diff? |
symonk
commented
Nov 28, 2022
|
|
|
Hah, yes, we need to add them to .gitignore. Sorry & thanks. |
titusfortner
requested changes
Nov 29, 2022
symonk
changed the title
stderr to exceptions when selenium manager failsstderr to exceptions when selenium manager fails
|
important to squash here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture
stderrwhen calling selenium manager and propogate the error to the user. This propagatesstderrto the user (andstdoutfor now). When selenium manager exits0we pass on the stripped path returned from its stdout.adds some unit tests for the manager aswell as we currently have none. I've made the
SeleniunManagerclass require an instance to use as its a single place we use it and I think we may want to build some internal state soon, rather than have a bunch of static methods in a class calling each other from the class directly.Thanks!
Relates to #11301