Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some typos #11035

Merged
merged 6 commits into from Sep 25, 2022
Merged

Fixed some typos #11035

merged 6 commits into from Sep 25, 2022

Conversation

shishurajpandey
Copy link
Contributor

@shishurajpandey shishurajpandey commented Sep 15, 2022 •
edited

Summary-
Just a minor code improvement, doesn't affect functionality.

Checklist

  • [x ] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

titusfortner
titusfortner requested changes Sep 15, 2022
View reviewed changes
Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! "behavior" is correct for US English; "behaviour" is British English.

java/src/com/thoughtworks/selenium/Selenium.java Outdated Show resolved Hide resolved
@titusfortner
Copy link
Member

Ran a basic search in the project because I was curious
behaviour - 536 times
behavior - 3200 times

Let's not change those, ok?

@shishurajpandey
Copy link
Contributor Author

Ran a basic search in the project because I was curious behaviour - 536 times behavior - 3200 times

Let's not change those, ok?

Sure.

@titusfortner titusfortner merged commit ff37292 into SeleniumHQ:trunk Sep 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shishurajpandey shishurajpandey deleted the patch-1 branch September 25, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titusfortner titusfortner titusfortner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shishurajpandey @CLAassistant @titusfortner