Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] build(setup.py): Add project_urls for PyPI #10880

Merged
merged 2 commits into from Aug 5, 2022

Conversation

tony
Copy link
Contributor

@tony tony commented Jul 15, 2022

Description

Show Project URLs to Selenium's PyPI page via project_urls to setup.py

image

Motivation and Context

It takes a few clicks to get around to the docs and source code. This makes it possible launch all of them via PyPI.

It also is helpful to anyone else that ingests the metadata from setup.py / PyPI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2022

CLA assistant check
All committers have signed the CLA.

@tony
Copy link
Contributor Author

tony commented Jul 25, 2022

@symonk Do you have a take on this?

py/setup.py Show resolved Hide resolved
py/setup.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #10880 (4664fe0) into trunk (f91fec5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10880   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files          84       84           
  Lines        5480     5480           
  Branches      279      279           
=======================================
  Hits         2764     2764           
  Misses       2437     2437           
  Partials      279      279           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@symonk
Copy link
Member

symonk commented Aug 5, 2022

test failures here are likely flakes at the minute, bidi tests need some TLC. fine to merge

@symonk
Copy link
Member

symonk commented Aug 5, 2022

Thanks @tony for the contribution, much appreciated. Apologies for the delays on review!

@symonk symonk merged commit 0d38875 into SeleniumHQ:trunk Aug 5, 2022
@tony tony deleted the project-urls branch August 5, 2022 20:59
@tony
Copy link
Contributor Author

tony commented Aug 5, 2022

You're welcome, Thank you @symonk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants