Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Remove assertion for python version check #10815

Merged
merged 1 commit into from Jul 5, 2022
Merged

[py] Remove assertion for python version check #10815

merged 1 commit into from Jul 5, 2022

Conversation

jsfehler
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Remove assertions that check if the python version is 3.7 or above.

Motivation and Context

  • New selenium versions only support python version 3.7+.
  • Pip will not install an incompatible selenium version.

Types of changes

Tech debt.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #10815 (12aecd1) into trunk (2fbfc62) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            trunk   #10815      +/-   ##
==========================================
- Coverage   50.46%   50.43%   -0.03%     
==========================================
  Files          84       84              
  Lines        5477     5472       -5     
  Branches      278      278              
==========================================
- Hits         2764     2760       -4     
+ Misses       2435     2434       -1     
  Partials      278      278              
Impacted Files Coverage Δ
py/selenium/webdriver/common/log.py 26.47% <ø> (-3.11%) ⬇️
py/selenium/webdriver/remote/webdriver.py 39.09% <ø> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbfc62...12aecd1. Read the comment docs.

py/selenium/webdriver/common/log.py Show resolved Hide resolved
@diemol
Copy link
Member

diemol commented Jun 27, 2022

@jsfehler can you please sign the CLA?

@titusfortner titusfortner merged commit 5532a8d into SeleniumHQ:trunk Jul 5, 2022
@jsfehler jsfehler deleted the fix_py37_assert branch July 5, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants