Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Throwing warnings for non-W3C before creating session #10741

Merged
merged 3 commits into from Jun 8, 2022
Merged

Conversation

diemol
Copy link
Member

@diemol diemol commented Jun 7, 2022

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This improves checking for non-W3C caps just before the session creation is requested. We were doing that when every capability was being set, which could throw false positives.

Motivation and Context

Removing JWP support in upcoming releases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol added the C-java label Jun 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@diemol
Copy link
Member Author

diemol commented Jun 8, 2022

Merging as Java CI passes.

@diemol diemol merged commit 9435a8a into trunk Jun 8, 2022
@diemol diemol deleted the check-caps branch June 8, 2022 09:42
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
…mHQ#10741)

* [java] Throwing warnings for non-W3C before creating session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant