Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeldonV2 - Ability to set component level labels/annotations in SeldonConfig/SeldonRuntime #5185

Open
ramanNarasimhan77 opened this issue Jan 13, 2024 · 0 comments
Labels

Comments

@ramanNarasimhan77
Copy link

ramanNarasimhan77 commented Jan 13, 2024

I noticed that both SeldonConfig and SeldonRuntime Custom Resources use v1.PodSpec to define podSpec for the components, and re-use the Annotations/Metadata set in the CustomResource in the Pod spec within Deployment/Statefulset.

References:
a) https://github.com/SeldonIO/seldon-core/blob/v2.6.0/operator/controllers/reconcilers/seldon/deployment_reconciler.go#L54..L55
b) https://github.com/SeldonIO/seldon-core/blob/60b7401ae5052ccf183c1453575611085bca4bb3/operator/controllers/reconcilers/seldon/statefulset_reconciler.go#L89..L90

Looking at this I understand there is no provision to set component specific labels - For example, if I wanted to set some custom labels/annotations for the seldon-scheduler, and some different labels/annotations for Envoy, I could not find a way to do so.

My goal is to be able to run all the Pods (except Envoy) defined in SeldonV2 Runtime definition within Istio Service Mesh (i.e. inject istio sidecar). One option I considered was to add the Istio labels/annotations to the CustomResource definition but then I would not be able to selectively prevent istio-proxy injection to the Envoy pod.

Could you please provide guidance for this?

@ramanNarasimhan77 ramanNarasimhan77 changed the title Ability to set component level labels/annotations in SeldonConfig/SeldonRuntime to selectively run components in Istio Service Mesh SeldonV2 - Ability to set component level labels/annotations in SeldonConfig/SeldonRuntime Jan 17, 2024
@sakoush sakoush added the v2 label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants