From e30c82b4827358cafa2aed01da5c540a5b5ed5a0 Mon Sep 17 00:00:00 2001 From: RafalSkolasinski Date: Mon, 30 Aug 2021 14:47:07 +0100 Subject: [PATCH] include notebook nbqa as part of python lint (#3548) --- python/Makefile | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/python/Makefile b/python/Makefile index 89cf4ab11a..cb12900136 100644 --- a/python/Makefile +++ b/python/Makefile @@ -104,12 +104,12 @@ fmt: isort \ ./ ../testing/scripts ../operator/helm ../operator/hack \ --skip proto --skip seldon_core/proto --skip .eggs --skip .tox - nbqa black ../ \ - --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)" - nbqa isort ../ \ - --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)" + nbqa black \ + ../ --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)" + nbqa isort \ + ../ --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)" -lint: licenses +lint: black \ --check ./ ../testing/scripts \ --exclude "(proto|seldon_core/proto/|.eggs|.tox)" @@ -117,6 +117,10 @@ lint: licenses --check-only ./ ../testing/scripts \ --skip proto --skip seldon_core/proto --skip .eggs --skip .tox flake8 + nbqa black \ + ../ --check --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)" + nbqa isort \ + ../ --check-only --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)" # Check if licenses have changed git \ --no-pager diff \