Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpspec/prophecy is now explicitely needed for tests #1755

Closed
DavidPrevot opened this issue Aug 28, 2022 · 2 comments
Closed

phpspec/prophecy is now explicitely needed for tests #1755

DavidPrevot opened this issue Aug 28, 2022 · 2 comments
Labels

Comments

@DavidPrevot
Copy link
Contributor

Hi,

Since PHPUnit dropped phpspec/prophecy from its dependencies (sebastianbergmann/phpunit#5033), the following errors are triggered when running the testsuite with latest PHPUnit with, e.g., Monolog 2.

There were 4 errors:

1) Monolog\Handler\RedisHandlerTest::testPredisHandle
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".

/tmp/autopkgtest-lxc.gay1cg9e/downtmp/build.3UJ/src/tests/Monolog/Handler/RedisHandlerTest.php:45

2) Monolog\Handler\RedisPubSubHandlerTest::testPredisHandle
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".

/tmp/autopkgtest-lxc.gay1cg9e/downtmp/build.3UJ/src/tests/Monolog/Handler/RedisPubSubHandlerTest.php:47

3) Monolog\LoggerTest::testLog
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".

/tmp/autopkgtest-lxc.gay1cg9e/downtmp/build.3UJ/src/tests/Monolog/LoggerTest.php:148

4) Monolog\LoggerTest::testLogNotHandled
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".

/tmp/autopkgtest-lxc.gay1cg9e/downtmp/build.3UJ/src/tests/Monolog/LoggerTest.php:164

Regards

David

@stof
Copy link
Contributor

stof commented Aug 28, 2022

I suggest you to open a PR adding the dev requirement.

@DavidPrevot
Copy link
Contributor Author

Apologies, looks like it’s already handled, I messed up between the 2.x and 3.x branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants