Replace call_user_func #1480
Merged
Replace call_user_func #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
commented
Jul 8, 2020
| @@ -312,7 +312,7 @@ public function addRecord(int $level, string $message, array $context = []): boo | |||
|
|
|||
| try { | |||
| foreach ($this->processors as $processor) { | |||
| $record = call_user_func($processor, $record); | |||
| $record = $processor($record); | |||
There was a problem hiding this comment.
I believe this is the place where we might see the results of this.. all the others are not offering much in performance.. just in order to be consistent.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
https://github.com/fab2s/call_user_func
and
symfony/symfony#29309
thanks @fab2s