Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable unique_id in WebProcessor #1470

Closed
Krinkle opened this issue Jun 2, 2020 · 0 comments
Closed

Option to disable unique_id in WebProcessor #1470

Krinkle opened this issue Jun 2, 2020 · 0 comments
Labels
Milestone

Comments

@Krinkle
Copy link

Krinkle commented Jun 2, 2020

The Apache mod_unique_id module is installed and enabled for Wikimedia's deployment, however the MediaWiki application prefers X-Request-Id if it is set (which internal routing always sets now).

We're not quite yet ready to turn this module off, and we've already added logging of a reqId throgh our own processor.

It is currently confusing to developers that our Logstash messages contain both unique_id and reqId which are similar but only one is "correct".

As I understand it, the WebProcessor has a constructor option to control which fields are used, but unique_id currently bypasses this. Would you be option to a pach for making that work the same way?

@Krinkle Krinkle added the Feature label Jun 2, 2020
@Seldaek Seldaek added Bug and removed Feature labels Jul 8, 2020
@Seldaek Seldaek added this to the 1.x milestone Jul 8, 2020
@Seldaek Seldaek closed this as completed in c3a05db Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants