Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded character escaping for Slack/SlackRecord #1396

Closed
alies-dev opened this issue Nov 9, 2019 · 1 comment
Closed

Unneeded character escaping for Slack/SlackRecord #1396

alies-dev opened this issue Nov 9, 2019 · 1 comment
Labels

Comments

@alies-dev
Copy link
Contributor

The only one goal of using json_encode to prepare $record to send to slack is to stringify some types for better perception. json_encode uses flash escaping by default that provides bad user experience, especially for URL:

image

@Seldaek
Copy link
Owner

Seldaek commented Nov 13, 2019

Thanks for the fix, but it kinda conflicted with other changes I did to fix broader json encoding issues so I had to reimplement it. In any case it should now be fixed in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants