Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "modal-stepper" shared style #7336

Open
NicoTuxx opened this issue May 17, 2024 · 0 comments
Open

Improve "modal-stepper" shared style #7336

NicoTuxx opened this issue May 17, 2024 · 0 comments

Comments

@NicoTuxx
Copy link
Contributor

NicoTuxx commented May 17, 2024

At the moment, multiple modals shared a common style by adding class "modal-stepper", css rules being present in /theme in parsec-cloud.
Multiple things to decide here:

  • Is this usage specific to parsec-cloud only? if no, should be moved to megashark-lib
  • If you don't know the class, you risk to remove it or forget it, without knowing what it is doing, it would be better to:
    • have it as a ms-modal parameter (if possible to use it)
    • OR make a ms-modal-stepper with the goal to provide the style only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant