[WIP] Refactor checks in API auth commands #7306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmarcos
force-pushed
the
remove-duplicate-code-in-auth-routes
branch
from
da98bcb
to
e044900
Compare
mmmarcos
force-pushed
the
remove-duplicate-code-in-auth-routes
branch
from
e044900
to
0015180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
require_valid_organization_and_author(better name wanted!) decorator is added to remove duplicate code from API commands. Essentially, it checks that organization exists and is not expired, and that the author exists and is not revoked.It still needs some type hints improvements (see
TODOcomments) which may require further refactoring in PG components.Closes #7119