Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Server v3] Remove duplicated access check in block.create #7117

Open
vxgmichel opened this issue Apr 19, 2024 · 0 comments
Open

[Server v3] Remove duplicated access check in block.create #7117

vxgmichel opened this issue Apr 19, 2024 · 0 comments
Labels
A-Server Area: Server application I-Postgresql Impact: Postgresql issue

Comments

@vxgmichel
Copy link
Contributor

parsec-cloud/server/parsec/components/postgresql/block.py

Lines 268 to 270 in f1ccaa5

# TODO: this check is performed twice, which one do we want to remove?
if ret is None or not ret["has_access"]:
return BlockCreateBadOutcome.AUTHOR_NOT_ALLOWED

@vxgmichel vxgmichel changed the title Remove duplicated access check in block.create [Server v3] Remove duplicated access check in block.create Apr 19, 2024
@vxgmichel vxgmichel mentioned this issue Apr 19, 2024
Closed
@mmmarcos mmmarcos added I-Postgresql Impact: Postgresql issue A-Server Area: Server application labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Server Area: Server application I-Postgresql Impact: Postgresql issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmmarcos @vxgmichel