Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

article detail page - details #56

Closed
eplebel opened this issue May 3, 2019 · 3 comments
Closed

article detail page - details #56

eplebel opened this issue May 3, 2019 · 3 comments
Milestone
beta batch #1 fea...

Comments

@eplebel
Copy link
Contributor

eplebel commented May 3, 2019 •
edited

very simple article detail page as per this mockup:
(no data model changes required for this issue)
article-detail-page

it basically just displays a normal article card (w/out card), with the following minor changes:

  • it's displayed in its expanded state by default/upon page load
  • it cannot be collapsed
  • abstract text is not-trimmed (& cannot be minified)

the card will have normal actions on hover, including the link icon on the left and EDIT, LINK/UNLINK, & DELETE buttons on the right (for users with proper permissions). That is:

  • EDIT & DELETE buttons always displayed for admins;
  • for non-admins, EDIT button only for authors who have linked article to their author page;
  • UNLINK button appears only if an article is already linked to a user's author page;
  • LINK button appears only if it is NOT already linked to a user's author page.

(and later (in batch # 2 features), embedabble content will be displayed in a full-mode side panel; see Live demo)
@eplebel eplebel mentioned this issue May 3, 2019
Open
@eplebel eplebel added this to the beta batch #1 features milestone May 9, 2019
mickaobrien added a commit that referenced this issue Jul 19, 2019
@mickaobrien
Adds article detail page - Issue #56
da26112 
I extracted components for `ArticleContent` (all the stuff that was in the article card) and `ArticleActions` (the Edit, Link and Delete buttons) to allow the `ArticlePage` component to share as much of the existing layout as possible. The `ArticleContent` component has an `is_article_page` flag. If this is set to `true` then the article content starts off fully expanded, the abstract isn't truncated and the 'Show More' button is hidden.

There is still a bit of duplication between `ArticleList` and `ArticlePage` when it comes to the gallery and `ArticleEditor` logic. This is because the list shares one gallery and editor instance between all articles whereas the `ArticlePage` needs one for the individual article. This could possibly be improved later.
@mickaobrien
Copy link
Contributor

@eplebel I just pushed a commit for this, you can see an example on the staging site here: https://curate-science-staging-2.appspot.com/app/article/320

@eplebel
Copy link
Contributor Author

eplebel commented Jul 23, 2019 •
edited

wow, this is also looking very good. awesome job here!
i think you've covered all the requirements, i was not able to find any bugs/deviations (i even tested a non-admin user to maker sure they can only edit articles linked to their author page, and that also seems to be working as expected).

the only tiny tiny issue is that the loading spinner for the article list on the author page now seems to be missing (for example, compare https://curate-science-staging-2.appspot.com/app/author/etienne-lebel to author page article list on production: https://curatescience.org/app/author/etienne-p-lebel; loading spinner for author information still appears correctly).

really looking forward to seeing search/search results page! #55 (and once those are working, we can then link article titles (on the homepage and author pages) to their respective article detail pages).

@eplebel eplebel closed this as completed Jul 30, 2019
mickaobrien added a commit that referenced this issue Jul 31, 2019
@mickaobrien
Adds article detail page - Issue #56
6c4e834 
I extracted components for `ArticleContent` (all the stuff that was in the article card) and `ArticleActions` (the Edit, Link and Delete buttons) to allow the `ArticlePage` component to share as much of the existing layout as possible. The `ArticleContent` component has an `is_article_page` flag. If this is set to `true` then the article content starts off fully expanded, the abstract isn't truncated and the 'Show More' button is hidden.

There is still a bit of duplication between `ArticleList` and `ArticlePage` when it comes to the gallery and `ArticleEditor` logic. This is because the list shares one gallery and editor instance between all articles whereas the `ArticlePage` needs one for the individual article. This could possibly be improved later.
mickaobrien added a commit to mickaobrien/curate_science that referenced this issue Aug 16, 2019
@mickaobrien
Adds article detail page - Issue ScienceCommons#56
5a679b3 
I extracted components for `ArticleContent` (all the stuff that was in the article card) and `ArticleActions` (the Edit, Link and Delete buttons) to allow the `ArticlePage` component to share as much of the existing layout as possible. The `ArticleContent` component has an `is_article_page` flag. If this is set to `true` then the article content starts off fully expanded, the abstract isn't truncated and the 'Show More' button is hidden.

There is still a bit of duplication between `ArticleList` and `ArticlePage` when it comes to the gallery and `ArticleEditor` logic. This is because the list shares one gallery and editor instance between all articles whereas the `ArticlePage` needs one for the individual article. This could possibly be improved later.
mickaobrien added a commit that referenced this issue Aug 19, 2019
@mickaobrien
Adds article detail page - Issue #56
c0cc858 
I extracted components for `ArticleContent` (all the stuff that was in the article card) and `ArticleActions` (the Edit, Link and Delete buttons) to allow the `ArticlePage` component to share as much of the existing layout as possible. The `ArticleContent` component has an `is_article_page` flag. If this is set to `true` then the article content starts off fully expanded, the abstract isn't truncated and the 'Show More' button is hidden.

There is still a bit of duplication between `ArticleList` and `ArticlePage` when it comes to the gallery and `ArticleEditor` logic. This is because the list shares one gallery and editor instance between all articles whereas the `ArticlePage` needs one for the individual article. This could possibly be improved later.
@eplebel eplebel reopened this Sep 2, 2019
@eplebel
Copy link
Contributor Author

eplebel commented Sep 2, 2019 •
edited by mickaobrien

final outstanding issues for contract#1:

  • place article page content inside a paper card (same style, padding, etc. as article list article card), like so:
    article-page-card

@eplebel eplebel mentioned this issue Sep 9, 2019
Closed
mickaobrien added a commit that referenced this issue Sep 9, 2019
@mickaobrien
Put article page content in a card matching article list style - #56
7c5e0be
@eplebel eplebel closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
beta batch #1 features/feature improv...
Development

No branches or pull requests
2 participants
@mickaobrien @eplebel