Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split-attrs: improve the xdist error fix #5037

Closed
pp-mo opened this issue Oct 27, 2022 · 1 comment
Closed

split-attrs: improve the xdist error fix #5037

pp-mo opened this issue Oct 27, 2022 · 1 comment
Labels
Type: Feature Branch Highlight this for a feature branch

Comments

@pp-mo
Copy link
Member

pp-mo commented Oct 27, 2022

See the problems + workaround reported here and here.
The current fix is really pretty ugly.
A proper 'fix' probably belongs in pytest or pytest-xdists,
but maybe a neater workaround would be conceivable?

@pp-mo pp-mo changed the title Improve the xdist error fix split-attrs: improve the xdist error fix Oct 27, 2022
@pp-mo pp-mo added the Type: Feature Branch Highlight this for a feature branch label Nov 2, 2022
@pp-mo
Copy link
Member Author

pp-mo commented Nov 15, 2023

( History : this was originally introduced at 481459c in #4960. )

But I think at some point since, this problem has fixed itself.
#5584

I think it was to fix this (at least partly), that the test numbering was introduced in lib/iris/tests/integration/test_netcdf__loadsaveattrs.py,
in the classes TestRoundtrip and TestLoad
-- but for some reason not in TestSave

IIRC the numbering also intends to align the TestRoundtrip and TestLoad testcases (though this may be a bit broken now)
In any case, no real need to remove the numbering now.

So I think this issue is good to close !

@pp-mo pp-mo closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Branch Highlight this for a feature branch
Projects
No open projects
Development

No branches or pull requests

1 participant