Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make antlr optional #423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 23, 2024

Closes #313

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

@ocefpaf ocefpaf marked this pull request as ready for review April 23, 2024 15:33
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 23, 2024

I wanted to add a test without antlr-python-runtime but I have no idea how to do that in the complex tox/conda-lock/extra env file setup here. If someone wants to add that note that we would need to call pytest with pytest cf_units/tests to avoid collecting import errors, or use -continue-on-collection-errors to continue.

I can attest that this works. All the functionalities but latex parsing are available and the import error is informative enough, if/when someone tries to use latex.

@bjlittle bjlittle self-assigned this Apr 24, 2024
@ocefpaf ocefpaf requested a review from bjlittle April 26, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Can we make antlr4-python3-runtime==4.7.2 dependency optional?
3 participants