Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Airspeed Velocity benchmark results publish #90

Open
trexfeathers opened this issue Jun 23, 2021 · 5 comments
Open

Automatic Airspeed Velocity benchmark results publish #90

trexfeathers opened this issue Jun 23, 2021 · 5 comments

Comments

@trexfeathers
Copy link
Contributor

trexfeathers commented Jun 23, 2021

✨ Feature Request

Create an automated job to run asv gh-pages --rewrite, which uses the GitHub Pages infrastructure to create an ASV results dashboard (example).

Motivation

Easy visualisation of this project's performance over its commit history, in a shared standardised way, will aid in development and collaboration. It also improves the project's image by showing potential collaborators/users that coverage extends to routine performance monitoring.

NOTE: benchmarking is already part of the CI 'test harness', but this only produces numeric results and skips any particularly slow benchmarks.

More detail in here!

Expand for implementation ideas...

This was previously attempted but removed due to permissions/security concerns - see #88. It seems that a dedicated GitHub Action will probably be the right implementation - here is a good example.

Virtual machines that use shared resource - including those used for GHA, Cirrus and most/all other CI solutions - are vulnerable to variable performance, which is very unhelpful for performance testing! There are steps we should take to help compensate:

  • Publish results from a single continuous ASV run.
    • As opposed to the example above that forces ASV to recognise the machine as the same one each time, allowing just benchmarking new commits and appending their results to existing ones.
    • Avoids the following performance variability:
      • Variability between multiple GHA runs.
      • Variability on long time scales (e.g. GHA demand at different times of day).
      • Variability from GitHub periodically changing/upgrading their Actions architecture.
    • This will result in long run times. I initially suggest a full run+publish after every PR merge, but if this takes prohibitively long we can consider scheduling nightly/weekly/... runs.
  • Work with Airspeed Velocity's design to reduce the impact of noise.
    • ASV automatically performs repeats and applies statistics specifically with noise in mind.
    • A variety of configurability is on offer to further compensate for within-run noise if it is still a problem.
      Some of these could also be useful for the existing CI benchmarking (see the CLI commands and the benchmark scripts).
@github-actions
Copy link
Contributor

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Sep 22, 2021
@trexfeathers trexfeathers removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Sep 27, 2021
@github-actions
Copy link
Contributor

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Dec 27, 2021
@trexfeathers trexfeathers removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Jan 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Apr 4, 2022
@trexfeathers trexfeathers removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Jul 4, 2022
@trexfeathers trexfeathers removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Oct 3, 2022
@trexfeathers trexfeathers added Status: Work in progress and removed Stale: Closure warning This stale issue or pull-request has been marked for closure labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant