Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend regridder saving/loading to all regridders #357

Merged
merged 11 commits into from
May 30, 2024
Merged

Extend regridder saving/loading to all regridders #357

merged 11 commits into from
May 30, 2024

Conversation

stephenworsley
Copy link
Contributor

Closes #318

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 99.37500% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.92%. Comparing base (cf86c1d) to head (d812343).

❗ Current head d812343 differs from pull request most recent head f077809

Please upload reports for the commit f077809 to get more accurate results.

Files Patch % Lines
esmf_regrid/experimental/io.py 98.05% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   98.85%   98.92%   +0.07%     
==========================================
  Files          37       37              
  Lines        3929     4196     +267     
==========================================
+ Hits         3884     4151     +267     
  Misses         45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenworsley
Merge branch 'main' into generic_saving
24c342e 
* main:
  Move benchmark code from nox to bm_runner (SciTools-incubator#361)
  Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools-incubator#356)
  Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools-incubator#355)
  [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#336)
  Updated environment lockfiles (SciTools-incubator#344)
@stephenworsley stephenworsley marked this pull request as ready for review May 29, 2024 15:03
pp-mo
pp-mo requested changes May 30, 2024
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really competent to comment on all the mechanics here.
But I have raised some 'style' points, including docstrings that seem to need changing.

Also, I think it probably needs a changelog entry ?

esmf_regrid/experimental/io.py Show resolved Hide resolved
esmf_regrid/experimental/io.py Show resolved Hide resolved
esmf_regrid/experimental/io.py Show resolved Hide resolved
esmf_regrid/experimental/io.py Show resolved Hide resolved
esmf_regrid/tests/unit/experimental/io/test_round_tripping.py Show resolved Hide resolved
@pp-mo pp-mo mentioned this pull request May 30, 2024
Open
@pp-mo
Copy link
Member

pp-mo commented May 30, 2024

OK I think this is all good now

@pp-mo pp-mo merged commit d4f4c2d into SciTools-incubator:main May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees

@pp-mo pp-mo

@stephenworsley stephenworsley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support saving/loading of ESMFAreaweightedRegridder, ESMFBilinearRegridder and ESMFNearestRegridder.
2 participants
@stephenworsley @pp-mo