Ensure dtype is preserved after regridding #239
Conversation
|
Note: this will still change the dtype if you start with integer data (by design). This does mean that the dask array also will have to be changed to better align with the underlying data in this case. This should be a seperable issue which can be addressed in its own PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 98.85% 98.85% -0.01%
==========================================
Files 36 37 +1
Lines 3855 3929 +74
==========================================
+ Hits 3811 3884 +73
- Misses 44 45 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I'm not convinced that there aren't a few more cases to address here. I think I would create test examples where both weights + source_array can be integer / float32 / float64, and check that output dtypes are as expected in all those cases.
But I may have missed that dtypes for the weights array are always known, or more limited ?
|
@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time. |
github-actions
bot
added
the
Stale: Closure warning
stephenworsley
removed
the
Stale: Closure warning
|
|
* main: (42 commits) Update lockfiles and fix for new esmpy (SciTools-incubator#342) Fix for esmpy (SciTools-incubator#353) Fix usage of map_blocks (SciTools-incubator#338) Revert "Updated environment lockfiles (SciTools-incubator#335)" (SciTools-incubator#341) Updated environment lockfiles (SciTools-incubator#335) Bump actions/cache from 3 to 4 (SciTools-incubator#333) Bump actions/upload-artifact from 3 to 4 (SciTools-incubator#324) Bump actions/stale from 8.0.0 to 9.0.0 (SciTools-incubator#322) fix asv (SciTools-incubator#339) [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#330) Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools-incubator#334) Updated environment lockfiles (SciTools-incubator#327) [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#328) Updated environment lockfiles (SciTools-incubator#304) Add CITATION.cff (SciTools-incubator#319) updated for enums (SciTools-incubator#293) Flake8 compliant type checking. (SciTools-incubator#316) update to v0.10.dev0 (SciTools-incubator#314) Update to v0.9 (SciTools-incubator#313) First pass at mesh to mesh (SciTools-incubator#311) ... # Conflicts: # CHANGELOG.md # esmf_regrid/esmf_regridder.py # esmf_regrid/schemes.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* main: Move benchmark code from nox to bm_runner (SciTools-incubator#361) Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools-incubator#356) Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools-incubator#355) [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#336) Updated environment lockfiles (SciTools-incubator#344) # Conflicts: # CHANGELOG.md
* main: Ensure dtype is preserved after regridding (SciTools-incubator#239)
Adresses #238.