New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing "switch" role on OnyxSwitch #754

Closed

JoCa96 opened this issue Mar 25, 2024 · 0 comments

Assignees

Labels

bug dev

Milestone

Selection controls

Contributor

JoCa96 commented Mar 25, 2024 •

edited

We are missing the switch role for out OnyxSwitch.

Implementation details

Eslint rule is incorrect, see vue-a11y/eslint-plugin-vuejs-accessibility#932

The text was updated successfully, but these errors were encountered:

JoCa96 self-assigned this

JoCa96 added bug dev labels

JoCa96 mentioned this issue

fix(OnyxSwitch): add missing semantic switch role #755

Merged

JoCa96 added a commit that referenced this issue


          fix(OnyxSwitch): add missing semantic switch role (#755)

e52bb16

Relates to #754 

Add optional, but semantically helpful `role="switch"` to the
OnyxSwitch.
The “switch” role can be used directly on a native `<input
type="checkbox" />` as shown in the example on
https://www.w3.org/WAI/ARIA/apg/patterns/switch/examples/switch-checkbox/.

JoCa96 closed this as completed

mj-hof added this to the Selection controls milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment