Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nullify tunnel on close sauce connect #11

Merged
merged 2 commits into from Dec 13, 2018
Merged

nullify tunnel on close sauce connect #11

merged 2 commits into from Dec 13, 2018

Conversation

wKich
Copy link
Contributor

@wKich wKich commented Dec 13, 2018 •
edited by Saulis

Fix issue with "Cannot read property 'on' of null" when re-run tests in web ui

This change is Reviewable

@wKich
nullify tunnel on close sauce connect
45e32a9 
Fix issue with "Cannot read property 'on' of null" when re-run tests in web ui
limonte
limonte suggested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@limonte limonte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wKich for the PR, a couple of small changes needed:

lib/sauce.js Outdated Show resolved Hide resolved
lib/sauce.js Outdated Show resolved Hide resolved
limonte
limonte approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

I'll release a new version right away 🚀

@limonte limonte merged commit 63d8ad5 into Saulis:master Dec 13, 2018
@wKich
Copy link
Contributor Author

wKich commented Dec 13, 2018

Thanks a lot. I think you may close #8 because its duplicate

@wKich wKich deleted the patch-1 branch December 13, 2018 09:36
@limonte limonte mentioned this pull request Dec 13, 2018
Closed
@limonte
Copy link
Contributor

limonte commented Dec 13, 2018

https://github.com/Saulis/gemini-sauce/releases/tag/v1.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonte limonte limonte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wKich @limonte