Add support for nodenext moduleResolution #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #144 |
sindresorhus
requested changes
Jun 28, 2022
readme.md
Outdated
| @@ -153,7 +153,7 @@ These options will be overridden if a `tsconfig.json` file is found in your proj | |||
| } | |||
| ``` | |||
|
|
|||
| *Default options will apply if you don't override them explicitly.* You can't override the `moduleResolution` option. | |||
| *Default options will apply if you don't override them explicitly.* You can't override the `moduleResolution` option. `moduleResolution` is set to `nodenext` if `module` is `nodenext`, `node16` if `module` is `node16` or `node` otherwise. | |||
There was a problem hiding this comment.
It would be better to explain this using a code comment on line 139
| @@ -0,0 +1 @@ | |||
| module.exports.default = "foo"; | |||
source/test/fixtures/module-resolution/node16-from-package-json/package.json
Show resolved
Hide resolved
source/test/test.ts
Outdated
| @@ -138,6 +138,30 @@ test('allow specifying a lib in tsconfig.json', async t => { | |||
| verify(t, diagnostics, []); | |||
| }); | |||
|
|
|||
| test('use moduleResolution NodeNext when module is nodenext in tsconfig.json', async t => { | |||
There was a problem hiding this comment.
Suggested change
| test('use moduleResolution NodeNext when module is nodenext in tsconfig.json', async t => { | |
| test('use moduleResolution `nodenext` when module is `nodenext` in tsconfig.json', async t => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Sorry, failed to leave a description!
This change aims to set the
moduleResolutiontonodenextornode16when appropriate.This allows for using
nodenextfeatures insidetsdtest files, such asself-module imports, which I have tested here.This is the feature that I am missing to incorporate
tsdin dotcore64/p-from-callback#15Thanks!