Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for compatibility with @typescript-eslint/no-unsafe-call rule #120

Merged
merged 2 commits into from Jun 5, 2021
Merged

Add test for compatibility with @typescript-eslint/no-unsafe-call rule #120

merged 2 commits into from Jun 5, 2021

Conversation

BendingBender
Copy link
Collaborator

Closes #99

@BendingBender BendingBender mentioned this pull request Jun 4, 2021
Closed
@sindresorhus
Copy link
Collaborator

It passes because I worked around it in the lint config: xojs/eslint-config-xo-typescript@5d67296

When you remove linked workaround your test fails.

@BendingBender
Copy link
Collaborator Author

BendingBender commented Jun 5, 2021 •
edited

Yes, I know that you've made a workaround for this. I've reenabled this rule for this test (see https://github.com/SamVerschueren/tsd/pull/120/files#diff-c0316592149a0bea42c336d2b96889d6c72b0191d6ce058ed6df91073cf22f50R7) and I actually added a proof that it fails with a different construct for this rule (see https://github.com/SamVerschueren/tsd/pull/120/files#diff-7aba3dbc285f4db952e54a26767dd82ccf9db80fbc73636de365bf26f9de2b30R26) to be sure that the rule is actually enabled.

sindresorhus
sindresorhus requested changes Jun 5, 2021
View reviewed changes
source/test/eslint-compatibility.ts Outdated Show resolved Hide resolved
source/test/eslint-compatibility.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Collaborator

Sorry, I missed that. Then I guess it was fixed somewhere.

@sindresorhus sindresorhus merged commit 354f77d into tsdjs:main Jun 5, 2021
@BendingBender BendingBender deleted the test-eslint-compat branch June 5, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expectType is not compatible with @typescript-eslint/no-unsafe-call
2 participants
@BendingBender @sindresorhus