Replace TSLint with ESLint #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Jun 4, 2021
| @@ -63,10 +62,12 @@ const ignoreDiagnostic = ( | |||
| return 'preserve'; | |||
| } | |||
|
|
|||
| const diagnosticFileName = (diagnostic.file as SourceFile).fileName; | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| const diagnosticFileName = diagnostic.file!.fileName; | |||
There was a problem hiding this comment.
Shouldn't we guard diagnostic.file? Or is its optionality incorrect?
There was a problem hiding this comment.
It doesn't seem to have caused any problems yet. I don't really know whether it may actually be undefined.
There was a problem hiding this comment.
Yeah, it's not really related to this PR. Just thought I'd bring it up. We should be careful about ! in general unless we are 100% sure it cannot be undefined or null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.