Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple diagnostic errors in a single expectError assertion #103

Merged
merged 2 commits into from May 27, 2021
Merged

Handle multiple diagnostic errors in a single expectError assertion #103

merged 2 commits into from May 27, 2021

Conversation

BendingBender
Copy link
Collaborator

Fixes #87

@BendingBender BendingBender mentioned this pull request May 24, 2021
Open
SamVerschueren
SamVerschueren requested changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very small comments. Looks good! Thanks for working on this 🙏 !

source/lib/compiler.ts Show resolved Hide resolved
source/lib/compiler.ts Outdated Show resolved Hide resolved
@SamVerschueren SamVerschueren merged commit 87f7109 into tsdjs:master May 27, 2021
@SamVerschueren
Copy link
Collaborator

Awesome work @BendingBender 🙏 !

@BendingBender BendingBender deleted the handle-multiple-errors-in-single-expect-error branch May 27, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

@SamVerschueren SamVerschueren SamVerschueren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expectError on array arguments mismatch
3 participants
@BendingBender @SamVerschueren @sindresorhus