Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expectError directives to detect parameter count mismatches #102

Merged

Conversation

BendingBender
Copy link
Collaborator

This PR extends the errors swallowed by usage of expectError for the following 2 errors:

  • function argument count mismatch for overloaded functions
  • function type argument count mismatch for overloaded functions

@sindresorhus
Copy link
Collaborator

@BendingBender Can you fix the merge conflict?

@BendingBender BendingBender force-pushed the expect-error-for-parameter-counts branch from adc5eaa to 3baae2b Compare May 26, 2021 18:43
@BendingBender
Copy link
Collaborator Author

@sindresorhus done

@SamVerschueren
Copy link
Collaborator

@BendingBender It's probably because I just merged the other PR. Can you resolve them again 🙏 .

@BendingBender BendingBender force-pushed the expect-error-for-parameter-counts branch from 3baae2b to 64a0072 Compare May 27, 2021 20:24
@BendingBender
Copy link
Collaborator Author

@SamVerschueren done

@sindresorhus sindresorhus merged commit 8fe3924 into tsdjs:master May 28, 2021
@BendingBender BendingBender deleted the expect-error-for-parameter-counts branch May 28, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants