Update CI and fix using the gem on TruffleRuby #108
Merged
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* That constant is not defined on TruffleRuby.
* Useful to run it in forks.
eregon
changed the title
|
I would add TruffleRuby in CI but unfortunately these tests depend on quite a bit of CRuby specifics, and TruffleRuby does not currently track allocation of context-independent objects like Symbols (all) and String literals. |
|
oh nice, will do a release shortly |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107 #103
cc @nirvdrum
@SamSaffron Could you review, merge and make a release? (after CI passes of course)
Before this the gem fails on TruffleRuby, because
GC::INTERNAL_CONSTANTS[:RVALUE_SIZE]is rightly not defined on non-CRuby.