New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated request package with alternative #135
Comments
I find axios (https://www.npmjs.com/package/axios) works fine for OCAPI, webdav (i.e. for both text and binary content). Still works fine with commonjs and is promise-native. So if we ever want to drop support for node<12 (which itself is EOL in April anyway) we could use it async as well. I use it here for ocapi/webdav and AM: https://github.com/SalesforceCommerceCloud/b2c-tools/blob/main/lib/environment.js |
|
https://npmtrends.com/axios-vs-fetch-vs-got-vs-ky-vs-request-vs-simple-get-vs-superagent Looks like Axios is very reliable alternative. Currently, there're 3 warnings, and they're all related to npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 @tobiaslohr do you need any support on this? |
@gokaygurcan Yes, I do! Happy to get support for this. I think there are a few candidates, also see this thread request/request#3143. While there are personal preferences I think we should ensure that the replacement accounts at least for the following principles:
Thoughts? |
NPM package
request
has been deprecated. We should work to look out for suitable alternatives and start exploring them. One candidate might begot
(https://www.npmjs.com/package/got), however alternative options are welcome.The text was updated successfully, but these errors were encountered: