Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Rate Limiting in wallets.js #204

Open
BrosG opened this issue May 24, 2023 · 0 comments
Open

Implement Rate Limiting in wallets.js #204

BrosG opened this issue May 24, 2023 · 0 comments
Assignees
Labels

Comments

@BrosG
Copy link
Contributor

BrosG commented May 24, 2023

The file wallets.js doesn't seem to have any rate limiting or throttling mechanisms in place. This could leave the application vulnerable to brute-force attacks, especially when it comes to sensitive operations such as creating wallets and decrypting existing ones.
Suggestion: Implement rate limiting or throttling on sensitive endpoints to mitigate the risk of brute-force attacks. Express-rate-limit is a good library for rate limiting if you're using Express.js.
Code Example:
`const rateLimit = require("express-rate-limit");

const apiLimiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100
});

app.use("/api/", apiLimiter);
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants