Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATTR_NAME_HANA_FILTER - 3rd value should be variable SAPHanaFilter and not static string #167

Open
PeterPitterling opened this issue Jan 27, 2023 · 3 comments

Comments

@PeterPitterling
Copy link
Contributor

ATTR_NAME_HANA_FILTER=("hana_${sid}_glob_filter" "props" "ra-act-dec-lpa")

SAPHanaFilter=$(get_hana_attribute "X" "${ATTR_NAME_HANA_FILTER[@]}")

declare -u SAPHanaFilter='ra-act-dec-lpa'

@PeterPitterling
Copy link
Contributor Author

to be more precise
SAPHanaFilter is already declared

declare -u SAPHanaFilter='ra-act-dec-lpa'

use here instead of specifying same string again
ATTR_NAME_HANA_FILTER=("hana_${sid}glob_filter" "props" "ra-act-dec-lpa")
-->
ATTR_NAME_HANA_FILTER=("hana
${sid}_glob_filter" "props" "${SAPHanaFilter}")

@fmherschel
Copy link
Member

Still unclear what is the real benefit.

@PeterPitterling
Copy link
Contributor Author

currently the filter values 'ra-act-dec-lpa' are defined 2times .. the first declaration has no meaning .. if you want to change the default filter you have to change it in the second occurence

ATTR_NAME_HANA_FILTER=("hana_${sid}glob_filter" "props" "ra-act-dec-lpa")

this is different again for SAPHana and SAPHanaTopology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants