Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copypastor_url to copypastor_host #194

Open
FelixSFD opened this issue Jul 10, 2019 · 4 comments
Open

Change copypastor_url to copypastor_host #194

FelixSFD opened this issue Jul 10, 2019 · 4 comments

Comments

@FelixSFD
Copy link
Member

The RegEx in the feedback-command contains the URL entered in copypastor_url in the login properties. This can lead to problems. If it's set to HTTPS, the command won't accept HTTP-links.

By changing the property to copypastor_host, we can easily modify the RegEx to accept both

@FelixSFD FelixSFD added this to the 1.3 milestone Jul 10, 2019
@juliusfriedman
Copy link

The RegEx in the feedback-command contains the URL entered in copypastor_url in the login properties. This can lead to problems. If it's set to HTTPS, the command won't accept HTTP-links.

By changing the property to copypastor_host, we can easily modify the RegEx to accept both

I agree on fixing bugs so long as they are documented to not cause changes in behavior which are then therefor hard to define or explain in context to others (bugs etc.)

Please let me know where I can find the actual license and disclaimer amongst the other information requried to contribute to making som botz.

Especially flying 1x

@juliusfriedman
Copy link

See also Sed or Awk

@juliusfriedman
Copy link

And I don't like cats n e more than U do 🖌️

@Bhargav-Rao
Copy link
Member

Hi, thank you for helping out. We have some guidelines for contributing here https://github.com/SOBotics/Guttenberg/blob/develop/CONTRIBUTING.md. You can always ask us in chat or in here if you want any clarification. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants