Handle questions as a plain object {[name]: question} #885
Conversation
caub
force-pushed
the
patch-1
branch
2 times, most recently
from
bf48047
to
bf365e1
Compare
|
@SBoudrias Do you think we could do that? |
|
Hey, will this be merged one day? |
|
@codinghusi I gave up, using http://npm.im/prompt instead |
|
Oh nice, there's another package for that :) May I ask, what kind of problem you had with merging? As I could see, it had only problems with code formatting guidelines. |
caub
force-pushed
the
patch-1
branch
2 times, most recently
from
0bb05b2
to
5e79408
Compare
This is a breaking change, but I believe it's worth, it's easier to wrap a single question in []
and
```js
const { foo, bar } = await inquirer.prompt({
foo: {
message: '...',
default: '...',
},
bar: {
default: '...',
}
}):
```
looks better imo
and object literals keys are ordered (as long as they're not numeric)
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 93.30% 93.32% +0.01%
==========================================
Files 27 27
Lines 1121 1123 +2
Branches 23 23
==========================================
+ Hits 1046 1048 +2
Misses 75 75
Continue to review full report at Codecov.
|
|
We use prompt package because it's light, support json-schema and we don't need fancy highlighting Ok I fixed the eslint issues, I don't have more time to spend on this sorry, it'd probably need tests |
caub
force-pushed
the
patch-1
branch
2 times, most recently
from
8874fc1
to
059bc6d
Compare
|
Thanks for the PR. I think that's a good idea to reduce boilerplate a little. |
I think it's worth to support a questions object, like this:
it looks better imo,
{ foo, bar }visually matches the corresponding keys in the question objectand object literals keys are ordered (as long as they're not numeric)
This PR detects such an object, safely normally, since a question should contain a
nameprop, there can't be a conflict with a single question object