Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message renders repeatedly when text spans lines #1146

Merged
merged 1 commit into from Jul 22, 2022
Merged

fix: message renders repeatedly when text spans lines #1146

merged 1 commit into from Jul 22, 2022

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Jul 22, 2022

When the text is too long and spans lines, all keys that can cause interaction will cause the message to be displayed repeatedly.
The bottom is a reproduction of the bug:

1.checkbox(version: @inquirer/checkbox@0.0.23-alpha.0):
checkbox-repeat-render

2.select(version: @inquirer/select@0.0.22-alpha.0):
select-repeat-render

The rest also have this bug, I didn't record it as a gif.

System Info:
NodeJS 16.10.0
windows 10

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1146 (cd23263) into master (783ce82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   69.38%   69.38%           
=======================================
  Files           8        8           
  Lines         147      147           
  Branches       25       25           
=======================================
  Hits          102      102           
  Misses         27       27           
  Partials       18       18           
Impacted Files Coverage Δ
packages/core/src/lib/utils.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783ce82...cd23263. Read the comment docs.

Copy link
Owner

@SBoudrias SBoudrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SBoudrias SBoudrias merged commit edc49ce into SBoudrias:master Jul 22, 2022
@zonemeen zonemeen deleted the fix/message-repeat-render branch July 22, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants