Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): the initial value of prefix #1142

Merged
merged 1 commit into from Jul 19, 2022
Merged

feat(checkbox): the initial value of prefix #1142

merged 1 commit into from Jul 19, 2022

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Jul 19, 2022

If the prefix property in the checkbox type is not set to any value, it will show undefined, which looks weird, so i think need to set a default value.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1142 (a7a8bd0) into master (945e20a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   69.38%   69.38%           
=======================================
  Files           8        8           
  Lines         147      147           
  Branches       25       25           
=======================================
  Hits          102      102           
  Misses         27       27           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945e20a...a7a8bd0. Read the comment docs.

@SBoudrias SBoudrias merged commit 783ce82 into SBoudrias:master Jul 19, 2022
@SBoudrias
Copy link
Owner

Thanks!

@zonemeen zonemeen deleted the feat/prefix-initial-value branch July 20, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants