Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: breakLines regression versus paginated content #1108

Merged
merged 1 commit into from Apr 28, 2022

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Apr 27, 2022

This PR updated breakLines to use wrap-ansi. However, in doing so, we broke the paginator. It assumes that the return value will be of the same length as the original array, but that broken lines will be subarrays.

[This PR](SBoudrias#1106) updated `breakLines` to use `wrap-ansi`. However, in doing so, we broke the paginator. It assumes that the return value will be of the same length as the original array, but that broken lines will be subarrays.
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1108 (982024d) into master (9baee32) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files           4        4           
  Lines         169      169           
  Branches       22       22           
=======================================
  Hits          149      149           
  Misses          1        1           
  Partials       19       19           
Impacted Files Coverage Δ
packages/core/lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9baee32...982024d. Read the comment docs.

Copy link
Owner

@SBoudrias SBoudrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting... 🤦🏻 not exactly the most straightforward interface

Thanks for sending a fix so quickly!

@SBoudrias SBoudrias merged commit 647564a into SBoudrias:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants