Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix input of "rawlist" #1089

Merged
merged 2 commits into from Mar 9, 2022
Merged

fix input of "rawlist" #1089

merged 2 commits into from Mar 9, 2022

Conversation

RobInNYC
Copy link
Contributor

@RobInNYC RobInNYC commented Mar 1, 2022

This fixes a bug in the input processing of "rawlist". To reproduce the bug:

  • Run a rawlist configuration
  • Use the arrow keys to select an item
  • Then use the number keys to enter a specific item, and press enter
  • Get an "invalid option" error

Because the arrow keys record the selected index on the input line, when the user enters a specific index, an ultimately invalid index is processed by the code.

This works around that by not using the input line to record the selected index when using arrow keys. Instead it records the selected index in a private variable.

Rob O’Connor and others added 2 commits February 28, 2022 21:54
fix bug where using arrow keys and then entering a specific choice
via index would cause an "invalid response" error
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1089 (e850a8f) into master (baf4efe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files           4        4           
  Lines         171      171           
  Branches       23       23           
=======================================
  Hits          151      151           
  Misses          1        1           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf4efe...e850a8f. Read the comment docs.

@SBoudrias SBoudrias merged commit cdc867a into SBoudrias:master Mar 9, 2022
@SBoudrias
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants