New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add example for a simple regex match on an input #1087
chore: add example for a simple regex match on an input #1087
Conversation
Any reason to return a Promise in the example since the effective check is synchronous? |
Co-authored-by: Simon Boudrias <admin@simonboudrias.com>
It seemed to suggest it preferred a promise as a response! I will change it |
Yes and no, maybe examples are often async to be more easily extendable. Not against keeping the promise there, I was just wondering the rationale. Can you help fixing the linting errors? |
…es/Inquirer.js into lo/example/regex-validate-input
I think it is easier to understand without the promise so I've switched it. |
Can you approve the workflow and i'll resolve the linting from the latest version. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 4 4
Lines 171 171
Branches 23 23
=======================================
Hits 151 151
Misses 1 1
Partials 19 19 Continue to review full report at Codecov.
|
🎉 thanks! |
I hope you don't mind. I thought examples/ could do with a few more basic prompts in there. This is the first of a few I was thinking of. I will PR the others when I get time.