Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add example for a simple regex match on an input #1087

Merged

Conversation

lukeocodes
Copy link
Contributor

@lukeocodes lukeocodes commented Feb 21, 2022

I hope you don't mind. I thought examples/ could do with a few more basic prompts in there. This is the first of a few I was thinking of. I will PR the others when I get time.

@SBoudrias
Copy link
Owner

Any reason to return a Promise in the example since the effective check is synchronous?

Co-authored-by: Simon Boudrias <admin@simonboudrias.com>
@lukeocodes
Copy link
Contributor Author

Any reason to return a Promise in the example since the effective check is synchronous?

It seemed to suggest it preferred a promise as a response! I will change it

@SBoudrias
Copy link
Owner

SBoudrias commented Feb 23, 2022

Yes and no, maybe examples are often async to be more easily extendable. Not against keeping the promise there, I was just wondering the rationale.

Can you help fixing the linting errors?

@lukeocodes
Copy link
Contributor Author

I think it is easier to understand without the promise so I've switched it.

@lukeocodes
Copy link
Contributor Author

Can you approve the workflow and i'll resolve the linting from the latest version. Thanks!

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1087 (fe00620) into master (a1da6cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1087   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files           4        4           
  Lines         171      171           
  Branches       23       23           
=======================================
  Hits          151      151           
  Misses          1        1           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1da6cf...fe00620. Read the comment docs.

@SBoudrias SBoudrias merged commit baf4efe into SBoudrias:master Feb 25, 2022
@SBoudrias
Copy link
Owner

🎉 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants