Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more lodash #1068

Merged
merged 12 commits into from Nov 18, 2021
Merged

Remove more lodash #1068

merged 12 commits into from Nov 18, 2021

Conversation

jimmywarting
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1068 (c557dcd) into master (3a796d8) will decrease coverage by 0.20%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
- Coverage   88.50%   88.30%   -0.21%     
==========================================
  Files           4        4              
  Lines         174      171       -3     
  Branches       23       23              
==========================================
- Hits          154      151       -3     
  Misses          1        1              
  Partials       19       19              
Impacted Files Coverage Δ
packages/core/index.js 88.46% <50.00%> (-0.11%) ⬇️
packages/core/lib/screen-manager.js 84.00% <100.00%> (-0.32%) ⬇️
packages/core/lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a796d8...c557dcd. Read the comment docs.

@SBoudrias SBoudrias changed the title remove more lodash Remove more lodash Nov 18, 2021
@SBoudrias SBoudrias merged commit 32854c0 into SBoudrias:master Nov 18, 2021
@SBoudrias
Copy link
Owner

Thanks!

@jimmywarting jimmywarting deleted the rm-lodash branch November 18, 2021 19:09
@jimmywarting jimmywarting restored the rm-lodash branch November 18, 2021 19:09
@jimmywarting jimmywarting deleted the rm-lodash branch November 18, 2021 19:09
@jimmywarting jimmywarting restored the rm-lodash branch November 18, 2021 19:09
@jimmywarting jimmywarting deleted the rm-lodash branch November 18, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants