fix: retain number prompt default #1020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number prompt wants to use the default value if the input was invalid, however after a keypress (and if the default value is truthy) the default gets cleared. This is done so the default value is not rendered in the prompt anymore, see: #719
This PR changes the logic so that instead of clearing the default value it sets a new state called "touched". We can then use this state to hide the default value from the rendered prompt.
Updated the relevant test so it would have failed before.