feat(prompt): progress indicator for filter and validate with optiona… #1002
+305
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensby
force-pushed
the
feature/progress
branch
4 times, most recently
from
7c4477d to
bc41425
Compare
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
- Coverage 93.43% 93.19% -0.25%
==========================================
Files 27 27
Lines 1143 1161 +18
Branches 25 25
==========================================
+ Hits 1068 1082 +14
- Misses 75 79 +4
Continue to review full report at Codecov.
|
dhensby
force-pushed
the
feature/progress
branch
2 times, most recently
from
0c3a41a to
2ff4037
Compare
dhensby
force-pushed
the
feature/progress
branch
2 times, most recently
from
0644697 to
75a12d1
Compare
|
OK - I've refactored/rebased this since there have been quite a few layout changes in terms of file locations, etc. I'm not sure how best to test these changes or increase the coverage - so any pointers on that would be appreciated. 🙏 |
SBoudrias
approved these changes
May 21, 2021
SBoudrias
approved these changes
May 21, 2021
|
Thanks! This is a great feature, I'm very happy to get this in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rebased the PR in #632 to try and help get this over the line.
Please let me know if there's anything else that needs to be done.
Closes #631