-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Object Page Component]: facets design inconsistencies #5811
Comments
Hello @ShirSAP and colleagues |
Hi @ShirSAP although the screenshots you posted don't contain any sensitive information, please be aware that this is a public GitHub repository and that we generally delete content that we think might be compromising or just shouldn't be made public. I only mention this to raise awareness - it's always better to be safe than sorry.
The Also, we're currently not offering any "Facet" components, so it's up to developers to define them on their end. If you feel like one of these facets should be available as component, please create a feature request for the respective component.
Since you have linked the specifications of the |
Hello @Lukas742, Appreciate your awareness comment and super quick response 😇 Hopefully he could get this to us soon. |
Hello @Lukas742 In the following example you'll see that everything looks good. Thank you and my apologies for the confusion. |
Bug Description
Today in the object page facet area, it seems that the display mode form are not using the correct parameters and padding.
This is how the component shows up without custom coding in our system:
Both the form label as well as the paddings are incorrect.
Affected Component
https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-objectpage--docs
Expected Behaviour
Form Label should use:
Form text value should use:
Taken from the following wiki: https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2697896853
In vertical layout the padding between label and text value should be:
Taken from the following wiki: https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698913658
Isolated Example
No response
Steps to Reproduce
...
Log Output, Stack Trace or Screenshots
No response
Priority
Medium
UI5 Web Components Version
1.18.0
Browser
Chrome
Operating System
OS
Additional Context
No response
Organization
SAP Build
Declaration
The text was updated successfully, but these errors were encountered: