Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Bar: Selected items not cleared after change in Adapt Filters dialog #5652

Open
1 task done
marekviskup opened this issue Apr 2, 2024 · 2 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@marekviskup
Copy link

Describe the bug

After a change of a filter value in the Adapt Filters dialog, clearing the filter bar doesn't result in previously selected filter items being removed.

Clear works fine unless the filter values are changed via Adapt Filters dialog.

Isolated Example

https://stackblitz.com/edit/github-rc93m5-rtmizd?file=src%2FFilterBarView.tsx

Reproduction steps

  1. Click on Adapt Filters button
  2. Click on Show Values button
  3. Select Option 1 for Filter 1
  4. Select Option 1 for Filter 2
  5. Click on OK button
  6. Click on Clear button

Expected Behaviour

Both filters are cleared -> all selected options are removed from the filter components.

Screenshots or Videos

No response

UI5 Web Components for React Version

1.26.1

UI5 Web Components Version

1.23.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@marekviskup marekviskup added the bug Something isn't working label Apr 2, 2024
@marekviskup
Copy link
Author

Hello,

Is there any plan to investigate this issue or are there any updates when this will be worked on?

Thank you.

@Lukas742
Copy link
Contributor

Lukas742 commented Jun 6, 2024

Hi @marekviskup

I investigated this issue already and unfortunately it turned out to be more complex than anticipated. We'll probably need a new concept for the FilterBar in general as our current approach isn't really how one would implement this component in React. We'll probably discuss the possible options next week and I'll let you know when there's an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants